Artem Kachitchkine wrote:
> 
>> a. Did you consider the DR case? See comment 2 above 
>> dls_devnet_rename(). Note that because a ddp->dd_vlanid could change 
>> (because of this case):
>>
>>    - dls_devnet_prop_load_task() needs lock protection when accessing 
>> the dd_vlanid field.
>>
>>    - in the case 2 of dls_devnet_rename(), you will need to unload the 
>> link properties associated with the old linkid and reapplies the link 
>> properties associated with the new linkid.
> 
> I'll look into it.
> 
>> c. Since link properties are all initialized by the new mechanism, do 
>> we still need the dladm_init_linkprop() calls in various RCM modules 
>> and libdladm function calls (for example, i_dladm_aggr_up())?
> 
> Will file a CR.
> 
Why don't fix it now?

>> Also, is it possible for "dladm init-linkprop" to take one specific 
>> name (which requires the changes in the do_init_linkprop() function)?
> 
> Yes, the code is already there.
> 
My question was: when dladm init-linkprop takes a specific link name?

Another problem I just think about. Do you need something similar to 
dls_devnet_prop_complete() when mac_open_by_linkid() is called? Or 
probably in dls_devnet_hold_tmp()?

Thanks
- Cathy

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to