On Fri, 2008-07-11 at 17:26 -0400, Anurag S. Maskey wrote: > Taking Seb's suggestion into account, I've modified the code and the > webrev is at http://cr.opensolaris.org/~anurag_m/CR-6620534/ for review.
This is much better, thank you. Only two new lines of code. :-) * General: I don't think this file is lint clean as there are some unused arguments in some functions. * 307,335,336,etc.: I'd prefer setting c_usage to NULL instead of the empty string for subcommands that have no usage. It's easier to read and you can compare against the NULL pointer instead of doing a strlen() at 831. * c_usage goes through gettext() at 832, but not when printed by die_opterr(). -Seb _______________________________________________ networking-discuss mailing list [email protected]
