> * General: I don't think this file is lint clean as there are some > unused arguments in some functions. > fixed the lint warnings (Now, I know what the /* ARGSUSED */ lines are for :) ) > * 307,335,336,etc.: I'd prefer setting c_usage to NULL instead of the > empty string for subcommands that have no usage. It's easier to read > and you can compare against the NULL pointer instead of doing a strlen() > at 831. > done > * c_usage goes through gettext() at 832, but not when printed by > die_opterr(). > I overlooked this one. added the gettext().
I've updated the webrev at http://cr.opensolaris.org/~anurag_m/CR-6620534/. Thanks Anurag _______________________________________________ networking-discuss mailing list [email protected]
