Hi Rishi, On Mon, 2009-08-03 at 15:46 -0400, Rishi Srivatsavai wrote: > Hello Seb, > > Sebastien Roy wrote: > > tools/scripts/bfu.sh > > > > * 8300-8362: I'm don't think I agree with the approach used here. One > > problem is that this won't work on OpenSolaris. Another is that > > you've duplicated the parsing of the file in bfu.sh while the > > parsing is already in dlmgmtd itself. This code is sure to be > > broken if the file format changes further. Instead, dlmgmtd could > > handle reading from the old format and writing to the new one. I > > don't see an actual need to have the file format changed before > > dlmgmtd runs. > > > > * 8317: There is no such thing as the "PPA hack" anymore. This is > > evidence that scripts in bfu.sh become obsolete and/or broken almost > > immediately. ;-) > > After offline chat with Seb we agreed that this code to handle > the upgrade of default_tag property was still needed. I will work > with Seb in adding similar support in OpenSolaris packaging.
Right, but the reference to the "PPA hack" is still unresolved. I don't think you need it given that Crossbow translates all of these to full-fledged VLAN links during upgrade. > > * 1473: There no real point to > > Typo? Yeah, I started to write a comment, then decided not to. :-) > > > * 1532: Why isn't /dev/dld the control device like it is for all other > > GLDv3 objects? > > We are using bridgectl for both ioctls and control messages from the > bridge daemon. For libdlbridge we will use the dld control device for > unprivileged ioctls as noted above. Sounds good. > > > * 2179: Is there any special handling for link up/down by anything > > related to bridging? > > Yes in bridged/dlpi.c there is handling of link up/down. Okay. > I will post an updated webrev once I have finished updates and testing the > changes > from code reviews. Thanks, -Seb _______________________________________________ networking-discuss mailing list [email protected]
