Anders Persson wrote: > Hi Rishi, > > On Tue, Aug 04, 2009 at 04:24:45PM -0400, Rishi Srivatsavai wrote: >>> * 107: Do you not need CONSTCOND to keep lint happy? >> I don't see any lint complaints in nightly output. >> > It does not look like the macro is being used, in which case lint wont > complain.
Ah okay. >>> * 102: Why does the message length impact the ethernet type? Should it not >>> always be TRILL (in the non-VLAN case)? >> It doesn't, we are using the msglen param to distinguish the two types: >> TRILL data >> packets and control IS-IS packets. >> > So are you expecting that msglen will always be less than ETHERMTU? msglen is needed for IS-IS traffic as IS-IS uses 802.3 header format that has the length field. When 0 is passed for TRILL traffic we use the Ethernet II header format and set type to TRILL ethertype. >>> * 871: Please add a trill_ prefix >> Not sure which one here, please specify. >> > My comment was referring to kstat_init. ACCEPT, I will add the trill prefix. Thanks, Rishi _______________________________________________ networking-discuss mailing list [email protected]
