Frank, I added comments as suggested. Webrev is updated here : http://cr.opensolaris.org/~dain/6768607/ <http://cr.opensolaris.org/%7Edain/6768607/>
Thanks, -Dai > >> what I'd definitively request to see is extending the comments >> preceeding rfs4_cbinfo_hold() to give hints about why our while loop >> goes: >> >> 355 while (cbp->cb_newer.cb_new == TRUE && >> cbp->cb_nullcaller == FALSE) { >> >> and the new bailout happens the other way around with: >> >> 365 if (cbp->cb_newer.cb_new == FALSE || >> cbp->cb_nullcaller == TRUE) >> >> I'm pretty sure, after this has been putbacked, and 3 or 4 months >> went over, >> nobody can explain that code immediately anymore... ;-) >> > I will add some comment here, and will update the webrev.