On Thu, 12 Mar 2009 22:38:28 +0100, Dai Ngo <Dai.Ngo at sun.com> wrote:
> > Frank, I added comments as suggested. > Webrev is updated here : http://cr.opensolaris.org/~dain/6768607/ thanks! that's what I had in mind. cheers frankB > > Thanks, > -Dai >> >>> what I'd definitively request to see is extending the comments >>> preceeding rfs4_cbinfo_hold() to give hints about why our while loop >>> goes: >>> >>> 355 while (cbp->cb_newer.cb_new == TRUE && >>> cbp->cb_nullcaller == FALSE) { >>> >>> and the new bailout happens the other way around with: >>> >>> 365 if (cbp->cb_newer.cb_new == FALSE || >>> cbp->cb_nullcaller == TRUE) >>> >>> I'm pretty sure, after this has been putbacked, and 3 or 4 months >>> went over, >>> nobody can explain that code immediately anymore... ;-) >>> >> I will add some comment here, and will update the webrev.
