> > The more I think about it, the more I like no retries. Maybe > I'm missing something, but why would the client drop/ignore > the first cbnull but process a subsequent cbnull? I'm thinking > that if it doesn't reply to the first, then it will probably not > reply to subsequent cb_null calls. It would be interesting to > know how many times our client fails to reply to cb_null. I > suspect that we'd see server either issue no retries or the > max number of retries and nothing in between. The intention of the change is to handle condition when the set_clientid_confirm somehow never comes. In this case the server (rfs4_do_cb_null()) never sends out any cb_null call and returns immediately causing rfs4_cbinfo_hold() to loop forever. If the set_clientid_confirm does arrive, rfs4_do_cb_null() will send the cb_null call and rfs4_cbinfo_hold() will break out of the loop immediately, regardless of the result of the call, since cb_new is no longer TRUE.
So the retries is to allow some time (5 secs) for the set_clientid_confirm to arrive, and not for retrying the cb_null call. -Dai
