Manno15 commented on a change in pull request #1972:
URL: https://github.com/apache/accumulo/pull/1972#discussion_r595405283
##########
File path:
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooQueueLock.java
##########
@@ -42,6 +42,19 @@
private String path;
private boolean ephemeral;
+ public static class FateLockPath {
+ private final String path;
+
+ public FateLockPath(String path) {
+ this.path = path;
+ }
+
+ @Override
Review comment:
I did have a few different versions of this. One with getPath and I even
had a method in `ZooLock` and `ZooQueueLock` to get the lock path at one point.
They all seemed readable to me so I stuck with what seemed to be the simplest
approach. If you think it adds good value to this then I can definitely add
that back in.
To be clear, are you suggesting renaming toString() to getPath() or
something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
