EdColeman commented on a change in pull request #1972:
URL: https://github.com/apache/accumulo/pull/1972#discussion_r595484170
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -106,11 +119,11 @@ public ZooLock(AccumuloConfiguration conf, String path,
UUID uuid) {
}
}
- protected ZooLock(ZooKeeper zookeeper, String path, UUID uuid) {
+ protected ZooLock(ZooKeeper zookeeper, ZooLockPath path, UUID uuid) {
Review comment:
This is one reason that I prefer an explicit getPath() - if for any
reason toString() was changed, it may be harder than it needs to be to find
places where the behavior of toString value is being used, esp with an
automatic conversion. But again, my opinion...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
