ctubbsii commented on a change in pull request #1972:
URL: https://github.com/apache/accumulo/pull/1972#discussion_r595519508
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -60,6 +60,19 @@ public String toString() {
}
+ public static class ZooLockPath {
+ private final String path;
+
+ public ZooLockPath(String path) {
+ this.path = path;
+ }
+
+ @Override
+ public String toString() {
+ return this.path;
+ }
+ }
+
Review comment:
@EdColeman These shouldn't be thought of as an object that *has* a
path... rather, they *are* path types. So, adding `getPath()` to these would
make them less concise and somewhat confusing (a path type with a getter for a
path type is confusing to me, anyway). I think having a proper `toString()`
here is sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
