dlmarion commented on a change in pull request #2346:
URL: https://github.com/apache/accumulo/pull/2346#discussion_r745572987
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java
##########
@@ -513,10 +522,17 @@ private synchronized void updateServerErrors(String
server, Exception e) {
log.error("Server side error on {}", server, e);
}
- private synchronized void updateUnknownErrors(String msg, Exception t) {
+ private synchronized void updateUnknownErrors(String msg, Throwable t) {
somethingFailed = true;
unknownErrors++;
- this.lastUnknownError = t;
+ // Multiple errors may occur between the time checkForFailures() is called
+ // by the client. Be sure to return an Error if one (or more) occurred.
+ // Set lastUnknownError if it's null, to an Error, or to an Exception if
it's not already an
+ // Error
+ if (this.lastUnknownError == null
+ || !(t instanceof Exception && this.lastUnknownError instanceof
Error)) {
Review comment:
I reworked this logic in 918b20f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
