keith-turner commented on a change in pull request #2346:
URL: https://github.com/apache/accumulo/pull/2346#discussion_r745643701
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ScannerIterator.java
##########
@@ -65,9 +67,9 @@
private ScannerImpl.Reporter reporter;
- private static ThreadPoolExecutor readaheadPool =
ThreadPools.createThreadPool(0,
Review comment:
> If you notice here the max threads is Integer.MAX_VALUE. Now that this
is not static anymore, what should the max value be?
oh I completely missed the int.max_val. I saw a 3 and thought that was the
max. So maybe there will not be a performance diff. The new max should
probably be lower. The scan code may never submit more than 1 or 2 task to the
pool. Not sure, would need to look at that code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
