keith-turner commented on a change in pull request #2346:
URL: https://github.com/apache/accumulo/pull/2346#discussion_r746875462
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ScannerIterator.java
##########
@@ -65,9 +67,9 @@
private ScannerImpl.Reporter reporter;
- private static ThreadPoolExecutor readaheadPool =
ThreadPools.createThreadPool(0,
Review comment:
> Do you think we should reuse the value of
BATCH_SCANNER_NUM_QUERY_THREADS for this, create a new property
SCANNER_NUM_QUERY_THREADS, or something else?
Looking at [this
code](https://github.com/apache/accumulo/blob/bf4d8e4ad5c06e2881a8235ffd0bb293c54289e4/core/src/main/java/org/apache/accumulo/core/clientImpl/ScannerIterator.java#L143-L146)
it seems like the read ahead thread pool on a per scanner basis would only
ever use a max one thread. With that in mind I don't think we need to make the
pool configurable, just create a pool with 0 to 1 threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
