ctubbsii commented on code in PR #103:
URL: https://github.com/apache/accumulo-examples/pull/103#discussion_r989407428
##########
pom.xml:
##########
@@ -100,7 +100,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-slf4j-impl</artifactId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
Review Comment:
> Related - but not part of this PR - the main accumulo project it looks
like the modules also need to have log4j-core added to have logging work when
running tests.
They only need it if they need to "run" (for tests, yes, for integration
tests, yes). Most of the "run" concept for our code is that our application
runs out of the distribution tarball, so we don't usually have to care, unless
we need it for tests (or the monitor, which I think uses it directly for
serializing log events for display on the monitor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
