ctubbsii commented on code in PR #103:
URL: https://github.com/apache/accumulo-examples/pull/103#discussion_r989407428
##########
pom.xml:
##########
@@ -100,7 +100,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-slf4j-impl</artifactId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
Review Comment:
> Related - but not part of this PR - the main accumulo project it looks
like the modules also need to have log4j-core added to have logging work when
running tests.
They only need it if they need to "run" (for tests, yes, for integration
tests, yes). Most of the "run" concept for our code is that our application
runs out of the distribution tarball, so we don't usually have to care, unless
we need it for tests (or the monitor, which I think uses it directly for
serializing log events for display on the monitor).
For these examples, though, it depends on whether we rely on any Maven
plugins in this examples repo "running" the code. I quote "running", because by
"run", I mean a plugin that executes code in our repository and uses the
"runtime" dependency scope to construct a classpath for that specific
execution. If we're just preparing a jar for users to put with a deployment of
Accumulo, where the runtime log4j-core library already exists, in order to
execute any of this code, then we don't need to declare it. If, however, we're
doing something like expect users to run exec-maven-plugin to run the examples,
then we do need to declare it as a runtime dependency.
Sorry if this explanation sounds like gibberish. It's tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
