ctubbsii commented on code in PR #103:
URL: https://github.com/apache/accumulo-examples/pull/103#discussion_r999510682
##########
pom.xml:
##########
@@ -100,7 +100,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-slf4j-impl</artifactId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
Review Comment:
> > Because of the bug mentioned in the Accumulo's own POM, it may also be
necessary to add log4j-core to the runtime dependencies, at least until that
bug is fixed.
>
> I may be a bit confused here. The scope of this dependency is `runtime`.
Is there more to do here?
Yes. You need to also add log4j-core as another runtime dependency, because
it is not automatically brought in transitively by log4j-slf4j2-impl like it
was with log4j-slf4j-impl (it should be, and may yet still be, once upstream
fixes the bug they made, but for now, it needs to be listed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
