cshannon commented on PR #3134: URL: https://github.com/apache/accumulo/pull/3134#issuecomment-1356818946
> > I'm wondering if this is a bug in 1.10, or if it only affected us after the upgrade to Thrift 0.17. If it affects 1.10, it would be good to backport, along with the integration test. However, we're not using JUnit5 in 1.10, so we'd have to write the IT a bit differently. > > Initially I thought this didn't apply but it does (my initial search didn't show the non blocking server being used). The test should be easy to convert to JUnit 4. My preference would be to keep this PR as it is for 2.1.1 so we can keep using JUnit 5 and merge it forward to main and i can create another PR for 1.10 that has the same fix but I'll fix the test so it's JUnit 4 which I'll do now. @ctubbsii - I updated based on your comments and things should be good now. I went to backport this to 1.10 and when I did I just noticed that the maxFrameSize option doesn't exist and wasn't added until this PR: https://github.com/apache/thrift/pull/2533 So this doesn't actually apply to 1.10 ....or at least if it is the same bug we can't apply this fix. I'm now wondering if the issue with #3094 is not easily fixable do to this option not being added yet. The answer might simply be to upgrade the version of thrift which supports the option and to a version where we set it which would imply to upgrade to Accumulo 2.1.1 when we release the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
