ctubbsii commented on code in PR #3134:
URL: https://github.com/apache/accumulo/pull/3134#discussion_r1052560856
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -221,7 +223,8 @@ private static ServerAddress
createThreadedSelectorServer(HostAndPort address,
long timeBetweenThreadChecks, long maxMessageSize) throws
TTransportException {
final TNonblockingServerSocket transport =
- new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()));
+ new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()), 0,
+ Ints.saturatedCast(maxMessageSize));
Review Comment:
I think we do have an RPC timeout configuration option. I'd be curious to
know if that is being set elsewhere and needs to be set here as well. Just as
with the max message size, it seems there's likely more than one place we need
to set these... here, and wherever we're currently setting them before these
new constructors became available to us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
