cshannon commented on code in PR #3134:
URL: https://github.com/apache/accumulo/pull/3134#discussion_r1052602005
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -221,7 +223,8 @@ private static ServerAddress
createThreadedSelectorServer(HostAndPort address,
long timeBetweenThreadChecks, long maxMessageSize) throws
TTransportException {
final TNonblockingServerSocket transport =
- new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()));
+ new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()), 0,
+ Ints.saturatedCast(maxMessageSize));
Review Comment:
I figured there may be a timeout option already and I could try and update
this PR to include it but I didn't know how much refactoring that would take
and didn't want to bloat the scope of this PR and thought it would be better as
a separate issue to add in. I can create a new issue if you want so we don't
forget to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
