cshannon commented on code in PR #3134:
URL: https://github.com/apache/accumulo/pull/3134#discussion_r1063673461
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -221,7 +223,8 @@ private static ServerAddress
createThreadedSelectorServer(HostAndPort address,
long timeBetweenThreadChecks, long maxMessageSize) throws
TTransportException {
final TNonblockingServerSocket transport =
- new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()));
+ new TNonblockingServerSocket(new InetSocketAddress(address.getHost(),
address.getPort()), 0,
+ Ints.saturatedCast(maxMessageSize));
Review Comment:
I opened up #3153 to investigate the RPC issue and I took a look and it
looks like we should indeed to be setting the value of that property as part of
the constructor argument for client timeout. We are using the property as it is
returned as part of context.getclientTimeoutInMillis() and passed to the
utility class
[here](https://github.com/apache/accumulo/blob/c31194740080a1f12c65aec82fe46731f9da2069/server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java#L198)
but it appears we are only using it for the blocking servers but not for non
blocking so it should be an easy fix to do it. I will update this PR to include
that change as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
