keith-turner commented on code in PR #3887: URL: https://github.com/apache/accumulo/pull/3887#discussion_r1370711366
########## server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/CompactionStrategy.java: ########## @@ -28,6 +28,12 @@ /** * The interface for customizing major compactions. * <p> + * Important: Compaction configurations should use one compaction scheme, either the Review Comment: This is not quite correct. The compaction strategy was a per table or per compaction configured item, the replacement for its functionality are the CompactionSelector and CompactionConfigurer plugins which can also be configured per table or per compaction. An attempt to explain this is here[here](https://github.com/apache/accumulo/blob/e6cbdb4418d50e6c3c99e166a0390e483401fded/core/src/main/java/org/apache/accumulo/core/client/admin/CompactionStrategyConfig.java#L40C85-L40C85). The CompactionPlanner is not a replacement for the CompactionStrategy. The compaction planner is a tserver level plugin and it break files selected by the CompactionStrategy (if confugred) into one or more compaction jobs that are scheduled on thread pools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
