keith-turner commented on code in PR #3887:
URL: https://github.com/apache/accumulo/pull/3887#discussion_r1394769020


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/CompactionStrategy.java:
##########
@@ -28,6 +28,12 @@
 /**
  * The interface for customizing major compactions.
  * <p>
+ * Important: Compaction configurations should be migrated to use the new 
compaction model as soon
+ * as possible. Only one compaction model should be configured and used at a 
time. Interactions
+ * between competing compaction scheme's file selection and scheduling may 
provide inconsistent
+ * results if both schemes are configured. The legacy compaction scheme has 
been maintained to
+ * support migrations to the new model and will be removed in the next major 
release.

Review Comment:
   ```suggestion
    * Important: Compaction configurations should be migrated to use only the 
new compaction plugins as soon
    * as possible.  Interactions
    * between this deprecated plugin with the new plugins may provide sub 
optimal and/or inconsistent
    * results when both are configured. This legacy compaction plugin has been 
maintained to
    * support migrations to the new model and will be removed in the next major 
release.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to