keith-turner commented on code in PR #3887:
URL: https://github.com/apache/accumulo/pull/3887#discussion_r1370923123


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/CompactionStrategy.java:
##########
@@ -28,11 +28,11 @@
 /**
  * The interface for customizing major compactions.
  * <p>
- * Important: Compaction configurations should use one compaction scheme, 
either the
- * {@link CompactionPlanner} introduced in 2.1, or a CompactionStrategy (see 
deprecation section).
+ * Important: Compaction configurations should use one compaction scheme, 
either the new

Review Comment:
   Even when using the CompactionStrategy, parts of the new scheme (like the 
planner) will still come into play because we can not have two separate 
implementations. Not sure of the best way to word it but need to convey the 
following.
   
    * Continued use of the CompactionStrategy is suboptimal
    * Continued support for the CompactionStrategy was only provided to give 
time to migrate to the new and improved plugins.  Users need to migrate ASAP in 
order to have a better experience.
    * The CompactionStrategy will be removed in the next major release.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to