keith-turner commented on code in PR #3955:
URL: https://github.com/apache/accumulo/pull/3955#discussion_r1396406969
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java:
##########
@@ -1068,6 +1069,38 @@ void
compactionFailed(Map<ExternalCompactionId,KeyExtent> compactions) {
.findFirst().map(Map.Entry::getKey).orElse(null);
LOG.debug("Unable to remove failed compaction {} {}", extent,
ecid);
}
+ } else {
+
+ // compactionFailed is called from the Compactor when either a
compaction fails or
+ // is cancelled and it's called from the DeadCompactionDetector.
This block is
+ // entered when the conditional mutator above successfully deletes
an ecid from
+ // the tablet metadata. Remove compaction tmp files from the tablet
directory
+ // that have a corresponding ecid in the name.
+ String dirName = ctx.getAmple().readTablet(extent,
ColumnType.DIR).getDirName();
Review Comment:
ExternalCompaction_3_IT.testMergeCancelsExternalCompaction() was disabled.
I tried running it and it passed so I pushed a commit to enable it. Did not
bother with a PR since it was a single line change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
