dlmarion commented on code in PR #3955:
URL: https://github.com/apache/accumulo/pull/3955#discussion_r1397881030
##########
core/src/main/java/org/apache/accumulo/core/metadata/ReferencedTabletFile.java:
##########
@@ -97,6 +97,8 @@ private static String constructErrorMsg(Path filePath) {
public static FileParts parsePath(Path filePath) {
// File name construct: <volume>/<tablePath>/<tableId>/<tablet>/<file>
// Example: hdfs://namenode:9020/accumulo/tables/1/default_tablet/F00001.rf
+ // Example compaction tmp file:
+ //
hdfs://namenode:9020/accumulo/tables/1/default_tablet/F00001.rf_tmp_ECID%3A<uuid>
Review Comment:
```suggestion
//
hdfs://namenode:9020/accumulo/tables/1/default_tablet/F00001.rf_tmp_ECID-<uuid>
```
##########
server/base/src/main/java/org/apache/accumulo/server/tablets/TabletNameGenerator.java:
##########
@@ -67,11 +68,12 @@ public static ReferencedTabletFile
getNextDataFilename(FilePrefix prefix, Server
}
public static ReferencedTabletFile getNextDataFilenameForMajc(boolean
propagateDeletes,
- ServerContext context, TabletMetadata tabletMetadata, Consumer<String>
dirCreator) {
+ ServerContext context, TabletMetadata tabletMetadata, Consumer<String>
dirCreator,
+ ExternalCompactionId ecid) {
String tmpFileName = getNextDataFilename(
!propagateDeletes ? FilePrefix.MAJOR_COMPACTION_ALL_FILES :
FilePrefix.MAJOR_COMPACTION,
- context, tabletMetadata.getExtent(), tabletMetadata.getDirName(),
dirName -> {}).insert()
- .getMetadataPath() + "_tmp";
+ context, tabletMetadata.getExtent(), tabletMetadata.getDirName(),
dirCreator).insert()
Review Comment:
Note that `dirCreator` was unused prior to this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
