dlmarion commented on code in PR #3955: URL: https://github.com/apache/accumulo/pull/3955#discussion_r1398040431
########## server/base/src/main/java/org/apache/accumulo/server/util/FindCompactionTmpFiles.java: ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.util; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; + +import org.apache.accumulo.core.metadata.schema.Ample.DataLevel; +import org.apache.accumulo.core.metadata.schema.ExternalCompactionId; +import org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType; +import org.apache.accumulo.core.trace.TraceUtil; +import org.apache.accumulo.core.util.UtilWaitThread; +import org.apache.accumulo.core.volume.Volume; +import org.apache.accumulo.server.ServerContext; +import org.apache.accumulo.server.cli.ServerUtilOpts; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.Path; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.beust.jcommander.Parameter; + +import io.opentelemetry.api.trace.Span; +import io.opentelemetry.context.Scope; + +public class FindCompactionTmpFiles { + + private static final Logger LOG = LoggerFactory.getLogger(FindCompactionTmpFiles.class); + + static class Opts extends ServerUtilOpts { + + @Parameter(names = "--tables", description = "comma separated list of table names") + String tables; + + @Parameter(names = "--delete", description = "if true, will delete tmp files") + boolean delete = false; + } + + public static List<Path> findTempFiles(ServerContext context, String tableId) + throws InterruptedException { + String tablePattern = tableId != null ? tableId : "*"; + final String pattern = "/tables/" + tablePattern + "/*/*"; + final Collection<Volume> vols = context.getVolumeManager().getVolumes(); + final ExecutorService svc = Executors.newFixedThreadPool(vols.size()); + final List<Path> matches = new ArrayList<>(1024); + final List<Future<Void>> futures = new ArrayList<>(vols.size()); + for (Volume vol : vols) { + final Path volPattern = new Path(vol.getBasePath() + pattern); + LOG.info("Looking for tmp files that match pattern: {}", volPattern); + futures.add(svc.submit(() -> { + try { + FileStatus[] files = vol.getFileSystem().globStatus(volPattern, + (p) -> p.getName().contains("_tmp_" + ExternalCompactionId.PREFIX)); + Arrays.stream(files).forEach(fs -> matches.add(fs.getPath())); + } catch (IOException e) { + LOG.error("Error looking for tmp files in volume: {}", vol, e); + } + return null; + })); + } + svc.shutdown(); + + while (futures.size() > 0) { + UtilWaitThread.sleep(10_000); + Iterator<Future<Void>> iter = futures.iterator(); + while (iter.hasNext()) { + Future<Void> future = iter.next(); + if (future.isDone()) { + iter.remove(); + try { + future.get(); + } catch (InterruptedException | ExecutionException e) { + throw new RuntimeException("Error getting list of tmp files", e); + } + } + } + } + svc.awaitTermination(10, TimeUnit.MINUTES); + LOG.debug("Found compaction tmp files: {}", matches); + + // Remove paths of all active external compaction output files from the set of + // tmp files found on the filesystem. This must be done *after* gathering the + // matches on the filesystem. + context.getAmple().readTablets().forLevel(DataLevel.ROOT).fetch(ColumnType.ECOMP).build() + .forEach(tm -> { + tm.getExternalCompactions().values() + .forEach(ecm -> matches.remove(ecm.getCompactTmpName().getPath())); + }); + context.getAmple().readTablets().forLevel(DataLevel.METADATA).fetch(ColumnType.ECOMP).build() + .forEach(tm -> { + tm.getExternalCompactions().values() + .forEach(ecm -> matches.remove(ecm.getCompactTmpName().getPath())); + }); + context.getAmple().readTablets().forLevel(DataLevel.USER).fetch(ColumnType.ECOMP).build() + .forEach(tm -> { + tm.getExternalCompactions().values() + .forEach(ecm -> matches.remove(ecm.getCompactTmpName().getPath())); + }); Review Comment: TODO: Turn this into one loop using the DataLevel as the loop variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
