kevinrr888 commented on code in PR #5646:
URL: https://github.com/apache/accumulo/pull/5646#discussion_r2145935396
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -582,10 +582,11 @@ public void run() {
}
private boolean shouldCleanupMigration(TabletMetadata tabletMetadata) {
+ if (!tabletMetadata.hasMigration()) {
+ return false;
+ }
var tableState =
getContext().getTableManager().getTableState(tabletMetadata.getTableId());
var migration = tabletMetadata.getMigration();
- Preconditions.checkState(migration != null,
- "This method should only be called if there is a migration");
Review Comment:
I'm not sure if this is a permanent fix.
We could merge this in as a temporary fix though.
Should verify the filter is doing what we think it's doing. If it's the case
that "the migration was removed after the filter ran, but before the
TabletMetadata was returned, by some other process." like you said, this might
be an okay permanent fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
