dlmarion commented on code in PR #5646:
URL: https://github.com/apache/accumulo/pull/5646#discussion_r2146006011
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -582,10 +582,11 @@ public void run() {
}
private boolean shouldCleanupMigration(TabletMetadata tabletMetadata) {
+ if (!tabletMetadata.hasMigration()) {
+ return false;
+ }
var tableState =
getContext().getTableManager().getTableState(tabletMetadata.getTableId());
var migration = tabletMetadata.getMigration();
- Preconditions.checkState(migration != null,
- "This method should only be called if there is a migration");
Review Comment:
So, the filter runs on the metadata tablet server and then the tablet
metadata is shipped back to the caller, the Manager in this case. I'm not sure
if a modification to the tablet metadata in between the evaluation and the
transfer can occur or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
