dlmarion commented on code in PR #5646:
URL: https://github.com/apache/accumulo/pull/5646#discussion_r2145943958
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -582,10 +582,11 @@ public void run() {
}
private boolean shouldCleanupMigration(TabletMetadata tabletMetadata) {
+ if (!tabletMetadata.hasMigration()) {
+ return false;
+ }
var tableState =
getContext().getTableManager().getTableState(tabletMetadata.getTableId());
var migration = tabletMetadata.getMigration();
- Preconditions.checkState(migration != null,
- "This method should only be called if there is a migration");
Review Comment:
Regarding, "the migration was removed after the filter ran, but before the
TabletMetadata was returned, by some other process," I'm not sure if that's the
case or not. It's a guess because the filter is pretty simple. We likely need
@keith-turner to weigh in on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
