ctubbsii commented on PR #5886: URL: https://github.com/apache/accumulo/pull/5886#issuecomment-3304019156
> > > Also we have #5855 open, we may be able to close that if an exception is ok. > > > > > > I think that one needs to be open for 2.1 pre-upgrade to 4.0. > > I commented on #5855, but I think the check should happen in the `start` command, not the `prepare` command. The `prepare` command is used on an older version and the user has the option to abort the upgrade even after running `prepare`. It doesn't necessarily make sense for the user to have to modify their property files for the older version at this phase. At the very least, a strong warning would make sense for the prepare stage, because it might be hard to run a tool in the newer version to move the configs to the namespace, if the ZK layout has changed in 4.0, and you haven't run the upgrade yet, but still want the properties to be in effect on startup of 4.0. In such a case, the 4.0 tooling to edit the config to put the props in a namespace (like ZooPropEditor) may not understand the 2.1 paths, and waiting until after the system is started and upgraded is too late for some table properties that you want to have set before you make it hosted (encryption, volume chooser, balancer, etc.). Such a tool could be run after the upgrade start stage, before Accumulo is running, if the start stage finished all the ZK upgrade steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
