ctubbsii commented on PR #5886: URL: https://github.com/apache/accumulo/pull/5886#issuecomment-3304465205
> > If a user wants them to be added to the namespaces automatically during the upgrade, they should set them in the system properties > > The error would tell the user to set the system properties using ZooPropEditor of the old version of software, or the 4.0 version? So, I think there's 3 places we need to warn or error: 1. 2.1.5 process startup -> should emit a WARNING instructing users that those properties will be disallowed in SiteConfiguration in the future, and recommend they add the desired config to the namespace or tables they want it to apply to (user has multiple choices about how to do that, so we don't need to provide very detailed instructions on which tool to use... because it's up to the user to decide namespaces vs. tables, ZooPropEditor vs. accumulo-shell vs. tableOperations() API, etc. 2. 2.1.5 `upgrade --prepare` -> should fail hard; the users have limited options at this point if they don't want to restart 2.1.5 to use the shell or the public API... so the best option is to put the config in the system config in ZK, and let the upgrade code in 4.0 migrate it to each namespace. they can use the 2.1.5 ZooPropEditor to add the configs to the system config, or they can use it to add it directly to the specific namespaces or tables they want to apply it to. 3. 4.0.0 `upgrade --start` -> should fail hard; at this point, the user doesn't have many options... they can't use ZooPropEditor at this point, because ZK hasn't been upgraded yet; they will have to remove the properties from the config file, complete the upgrade, and then add them to the namespaces or tables they want them to be applied to; *if* we are able to get all the upgrade code in a state so that the ZK layout can be completely upgraded after `upgrade --start` finishes, but *before* they start the cluster, they *could* use ZooPropEditor at that time, to add things to namespaces/tables before they are hosted... but that depends on what state the upgrade code is in when we release. The best option is for users to pay attention to the warning in item 1 above, the next best option is to use ZooPropEditor when they see an error in item 2 above. the worst option is waiting until after 4.0.0 is installed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
