dlmarion commented on PR #5886: URL: https://github.com/apache/accumulo/pull/5886#issuecomment-3304175780
I think @ctubbsii suggested a while back that some of the ZooKeeper upgrade validation / modifications could be performed in `upgrade --start`. There are already two items being performed (see [here](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/UpgradeUtil.java#L270-L283)). With the current changes `upgrade --start` will fail if there are table properties in the site config. The failure happens early in the process. I wonder if the validation of the site configuration should be bypassed initially, allowing `start` to set the properties in the system configuration in ZooKeeper. After that, could fail and tell the user to remove them from the file and try again. The 4.0 upgrader already moves the system properties to the namespace level [here](https://github.com/apache/accumulo/blob/main/server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader11to12.java#L920). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
