keith-turner commented on code in PR #5888:
URL: https://github.com/apache/accumulo/pull/5888#discussion_r2356381118
##########
server/base/src/main/java/org/apache/accumulo/server/util/UpgradeUtil.java:
##########
@@ -85,6 +120,20 @@ public void execute(String[] args) throws Exception {
ZooReaderWriter zoo = new ZooReaderWriter(siteConf);
if (opts.prepare) {
+ SortedMap<String,String> tablePropsInSite = new TreeMap<>();
+ // get table props in site conf excluding default config
+ siteConf.getProperties(tablePropsInSite,
+ key -> key.startsWith(Property.TABLE_PREFIX.getKey()), false);
+
+ if (!tablePropsInSite.isEmpty()) {
+ LOG.warn("Saw table properties in site configuration : {} ",
tablePropsInSite.keySet());
+ throw new IllegalStateException("Did not start upgrade preparation
because table properties"
Review Comment:
Changed to only warn in 9b1da5b because of two reasons. First the user does
not have to run upgrade prepare in 2.1. Second the place where they run it may
not have table props set in its site config, but other host in the cluster may
have table props set in site config. In this second case server will fail to
start in 4.0 and that may cause upgrade to fail. A lot of good points have
been brought up and we need to work out a good end to end method for reliably
dealing w/ this problem and document it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
