dlmarion commented on code in PR #5888:
URL: https://github.com/apache/accumulo/pull/5888#discussion_r2356398980
##########
server/base/src/main/java/org/apache/accumulo/server/util/UpgradeUtil.java:
##########
@@ -85,6 +120,17 @@ public void execute(String[] args) throws Exception {
ZooReaderWriter zoo = new ZooReaderWriter(siteConf);
if (opts.prepare) {
+ SortedMap<String,String> tablePropsInSite = new TreeMap<>();
+ // get table props in site conf excluding default config
+ siteConf.getProperties(tablePropsInSite,
+ key -> key.startsWith(Property.TABLE_PREFIX.getKey()), false);
+
+ if (!tablePropsInSite.isEmpty()) {
+ LOG.warn(
+ "Saw table properties in site configuration, these may cause
problems in later versions of Accumulo : {} ",
Review Comment:
```suggestion
"Saw table properties in site configuration, these may cause
problems in later versions of Accumulo. Consider setting these properties on
the namespace or table directly. Table properties found : {} ",
```
Maybe we can suggest an action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
