ddanielr commented on code in PR #5888:
URL: https://github.com/apache/accumulo/pull/5888#discussion_r2356833265
##########
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java:
##########
@@ -214,6 +214,11 @@ public static SiteConfiguration auto() {
private SiteConfiguration(Map<String,String> config) {
ConfigCheckUtil.validate(config.entrySet(), "site config");
+ config.forEach((prop, value) -> {
+ if (prop.startsWith(Property.TABLE_PREFIX.getKey())) {
+ log.warn("Setting table props in site configuration is deprecated, saw
{}", prop);
Review Comment:
Seeing this being printed twice in the tserver logs.
```
2025-09-17T21:11:41,229 [conf.SiteConfiguration] INFO : Found Accumulo
configuration on classpath at
/workspace/fluo-uno/install/accumulo-2.1.5-SNAPSHOT/conf/accumulo.properties
2025-09-17T21:11:41,236 [conf.SiteConfiguration] WARN : Setting table props
in site configuration is deprecated, saw table.durability
2025-09-17T21:11:41,236 [tserver.TabletServer] INFO : Bind address:
localhost, advertise address: null
2025-09-17T21:11:41,239 [conf.SiteConfiguration] INFO : Found Accumulo
configuration on classpath at
/workspace/fluo-uno/install/accumulo-2.1.5-SNAPSHOT/conf/accumulo.properties
2025-09-17T21:11:41,240 [conf.SiteConfiguration] WARN : Setting table props
in site configuration is deprecated, saw table.durability
```
Seems like the second message is coming from the logging appender
https://github.com/apache/accumulo/blob/93e44ec2adfd1d1fc308c3f5f054d8548e24592c/server/monitor/src/main/java/org/apache/accumulo/monitor/util/logging/AccumuloMonitorAppender.java#L153
Stacktrace:
```
at
org.apache.accumulo.core.conf.SiteConfiguration.<init>(SiteConfiguration.java:217)
~[accumulo-core-2.1.5-SNAPSHOT.jar:2.1.5-SNAPSHOT]
at
org.apache.accumulo.core.conf.SiteConfiguration$Builder.build(SiteConfiguration.java:181)
~[accumulo-core-2.1.5-SNAPSHOT.jar:2.1.5-SNAPSHOT]
at
org.apache.accumulo.core.conf.SiteConfiguration.auto(SiteConfiguration.java:210)
~[accumulo-core-2.1.5-SNAPSHOT.jar:2.1.5-SNAPSHOT]
at
org.apache.accumulo.monitor.util.logging.AccumuloMonitorAppender.lambda$new$1(AccumuloMonitorAppender.java:153)
~[accumulo-monitor-2.1.5-SNAPSHOT.jar:2.1.5-SNAPSHOT]
at
org.apache.accumulo.monitor.util.logging.AccumuloMonitorAppender.append(AccumuloMonitorAppender.java:186)
~[accumulo-monitor-2.1.5-SNAPSHOT.jar:2.1.5-SNAPSHOT]
at
org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:160)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:133)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:124)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:88)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:714)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:672)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:648)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.logParent(LoggerConfig.java:705)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:674)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:648)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:636)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:108)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.async.AsyncLogger.actualAsyncLog(AsyncLogger.java:577)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.async.RingBufferLogEvent.execute(RingBufferLogEvent.java:172)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.async.RingBufferLogEventHandler4.onEvent(RingBufferLogEventHandler4.java:54)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:32)
[log4j-core-2.24.3.jar:2.24.3]
at
org.apache.logging.log4j.core.async.RingBufferLogEventHandler4.onEvent(RingBufferLogEventHandler4.java:31)
[log4j-core-2.24.3.jar:2.24.3]
at
com.lmax.disruptor.BatchEventProcessor.processEvents(BatchEventProcessor.java:168)
[disruptor-3.4.4.jar:?]
at
com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:125)
[disruptor-3.4.4.jar:?]
at java.base/java.lang.Thread.run(Thread.java:840) [?:?]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
