ctubbsii commented on code in PR #5888:
URL: https://github.com/apache/accumulo/pull/5888#discussion_r2357335416
##########
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java:
##########
@@ -214,6 +214,11 @@ public static SiteConfiguration auto() {
private SiteConfiguration(Map<String,String> config) {
ConfigCheckUtil.validate(config.entrySet(), "site config");
+ config.forEach((prop, value) -> {
+ if (prop.startsWith(Property.TABLE_PREFIX.getKey())) {
+ log.warn("Setting table props in site configuration is deprecated, saw
{}", prop);
Review Comment:
We call it SiteConfiguration internally, but it no longer has the word
"site" in it (at least not by default) in any of the user-facing stuff. The log
message could display `accumulo.properties` instead, or if it knows the actual
filename used to construct this SiteConfiguration, it could display that, or it
could say something like "configuration files" or "startup config files".
Newcomers may not understand what a "site file" is, because they didn't work
with Accumulo when the file was called `accumulo-site.xml`
Also, I'm okay with being noisy here, but if you wanted to be less noisy,
you could use a stream collector to construct a message about all the
violations, and just emit one warning instead of many.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
