ddanielr commented on code in PR #5888:
URL: https://github.com/apache/accumulo/pull/5888#discussion_r2356879879


##########
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java:
##########
@@ -214,6 +214,11 @@ public static SiteConfiguration auto() {
 
   private SiteConfiguration(Map<String,String> config) {
     ConfigCheckUtil.validate(config.entrySet(), "site config");
+    config.forEach((prop, value) -> {
+      if (prop.startsWith(Property.TABLE_PREFIX.getKey())) {
+        log.warn("Setting table props in site configuration is deprecated, saw 
{}", prop);

Review Comment:
   Yeah I don't think it needs to be fixed. Just thought it was interesting.
   Removing the props from the file also removes the messages so that seems 
like an easy enough fix. 
   Going through the code, it looks like this message is going to be very loud 
since it will trigger for most of the CLI tooling (admin commands, 
GenerateSplits, etc). 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to