keith-turner commented on code in PR #91: URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2628762120
########## README.md: ########## @@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java) ``` mvn clean package -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE + +JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java Review Comment: Would be nice to avoid having the version number in the readme because it will have to be updated. Also w/o the env var its shorter. ```suggestion java --module-path=$(ls target/accumulo-access-*.jar) --add-modules=accumulo.access src/test/java/example/AccessExample.java ``` Looked into putting the example code into a module that requires the accumulo.access module and found this is not possible w/ this way of running it. These [docs](https://openjdk.org/jeps/330) mention the code is always run in the unamed module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
