dlmarion commented on code in PR #91: URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2630991968
########## README.md: ########## @@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java) ``` mvn clean package -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE + +JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java Review Comment: > Looked into putting the example code into a module that requires the accumulo.access module and found this is not possible w/ this way of running it. These [docs](https://openjdk.org/jeps/330) mention the code is always run in the unamed module. I feel like this should be possible. I'm thinking: 1. Put the example code in a module, let's call it `accumulo.access.examples` 2. In the examples module-info.java file, it would `requires accumulo.access` 3. Then, you would run the example by using the command: ``` java --module-path <dir> --module accumulo.access.examples/example.AccessExample ``` I can look at doing this after I merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
