keith-turner commented on code in PR #91: URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2631628475
########## README.md: ########## @@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java) ``` mvn clean package -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java -CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE + +JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java Review Comment: > do you have any issues with moving this to multi-module? Seems like a good experiment to me. We had looked into making accumulo itself use modules and got stuck on the thrift code. All the server modules in accumulo need to use the thrift code in accumulo-core. Looking into modules again as part of reviewing this realized we may be able to get around that blocker by having an accumulo-core module explicitly allow access to its internals for only the server modules. Not sure if that would work, but I think this project provides a good place to try things out w/ modules. So I would be in favor of trying to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
