dlmarion commented on code in PR #6049:
URL: https://github.com/apache/accumulo/pull/6049#discussion_r2709743374


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1190,15 +1220,35 @@ private List<TabletMigration> 
checkMigrationSanity(Set<TabletServerId> current,
               > MAX_BAD_STATUS_COUNT) {
             if (shutdownServerRateLimiter.tryAcquire()) {
               log.warn("attempting to stop {}", server);
-              try {
-                TServerConnection connection2 = 
tserverSet.getConnection(server);
-                if (connection2 != null) {
-                  connection2.halt(managerLock);
+              var gracefulHaltTimer = 
tserverHaltRpcAttempts.computeIfAbsent(server,

Review Comment:
   Was the intent to guard this new code with:
   ` if (forceHaltingEnabled) {`
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to