ddanielr commented on code in PR #6073:
URL: https://github.com/apache/accumulo/pull/6073#discussion_r2722459091
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -245,7 +245,7 @@ public void zap(SiteConfiguration siteConf, String... args)
{
if (opts.zapScanServers) {
String sserversPath = Constants.ZROOT + "/" + iid + Constants.ZSSERVERS;
try {
- removeGroupedLocks(zoo, sserversPath, groupPredicate,
hostPortPredicate, opts);
+ removeScanServerGroupLocks(zoo, sserversPath, hostPortPredicate,
groupPredicate, opts);
Review Comment:
(feel free to ignore): `removeScanServerGroupLocks` and `removeGroupedLocks`
take the same args but in different orders.
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
Review Comment:
```suggestion
static void removeCompactorGroupedLocks(ZooReaderWriter zoo, String path,
Predicate<String> groupPredicate,
```
This method does not exist in `main` and is only used by compactors so
rename it to be more precise in it's usage.
##########
assemble/bin/accumulo-cluster:
##########
@@ -796,7 +796,7 @@ function prune() {
read -r -a groups <<<"$ARG_SSERVER_GROUP"
else
# find all groups known in zookeeper, this will allow pruning entire
groups that do not even exist in cluster.yaml
- readarray -t groups < <(jq -r ".summaries.S_SERVER.resourceGroups | .[]
" "$service_json")
+ readarray -t groups < <(jq -r ".summaries.S_SERVER.resourceGroups | keys
| .[]?" "$service_json")
Review Comment:
Was this related to the fix or just handled a different error case when
resourceGroups aren't present?
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -328,7 +328,7 @@ public String getClientAddressString() {
}
/**
- * Set up nodes and locks in ZooKeeper for this Compactor
+ * Set up nodes and locks in ZooKeeper for this ScanServer
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
