dlmarion commented on code in PR #6073:
URL: https://github.com/apache/accumulo/pull/6073#discussion_r2722696800


##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -245,7 +245,7 @@ public void zap(SiteConfiguration siteConf, String... args) 
{
     if (opts.zapScanServers) {
       String sserversPath = Constants.ZROOT + "/" + iid + Constants.ZSSERVERS;
       try {
-        removeGroupedLocks(zoo, sserversPath, groupPredicate, 
hostPortPredicate, opts);
+        removeScanServerGroupLocks(zoo, sserversPath, hostPortPredicate, 
groupPredicate, opts);

Review Comment:
   When `--include-groups` is not set, then the group predicate is set to just 
`true`, which should match all groups. This is done on line  151 above. Do you 
think that will not work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to