ddanielr commented on code in PR #6073:
URL: https://github.com/apache/accumulo/pull/6073#discussion_r2722696723
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -245,7 +245,7 @@ public void zap(SiteConfiguration siteConf, String... args)
{
if (opts.zapScanServers) {
String sserversPath = Constants.ZROOT + "/" + iid + Constants.ZSSERVERS;
try {
- removeGroupedLocks(zoo, sserversPath, groupPredicate,
hostPortPredicate, opts);
+ removeScanServerGroupLocks(zoo, sserversPath, hostPortPredicate,
groupPredicate, opts);
Review Comment:
I don't think that's necessary. If the resource group is not defined then
the GroupPredicate is set to true.
https://github.com/apache/accumulo/blob/e689a8fb7133464f08e5d69623d199703ce7c8a7/server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java#L146-L152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
