kevinrr888 commented on code in PR #6025:
URL: https://github.com/apache/accumulo/pull/6025#discussion_r2742453531
##########
server/base/src/main/java/org/apache/accumulo/server/tablets/TabletTime.java:
##########
@@ -87,6 +89,8 @@ public MetadataTime getMetadataTime(long time) {
}
@Override
+ @SuppressFBWarnings(value = "AT_NONATOMIC_64BIT_PRIMITIVE",
+ justification = "this is only called in tablet constructor, so does
not need to be done atomically")
public void useMaxTimeFromWALog(long time) {
Review Comment:
Made changes to `TabletTime.MillisTime` (`TabletTime.LogicalTime` didn't
need any changes) in 0b96b0898ca296e6a2771416854a1e44d7712786. Also made
`updateTime()` synchronized. Only called in sync blocks but should itself be
sync in case that changes, and its not any more expensive to declare it sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
