spacewander commented on code in PR #7517:
URL: https://github.com/apache/apisix/pull/7517#discussion_r928249785
##########
t/plugin/clickhouse-logger.t:
##########
@@ -149,7 +161,7 @@ property "endpoint_addr" is required
"password": "a",
"database": "default",
"logtable": "t",
- "endpoint_addr":
"http://127.0.0.1:10420/clickhouse-logger/test";,
+ "endpoint_addrs":
["http://127.0.0.1:10420/clickhouse-logger/test";],
Review Comment:
We can keep an old test to test the compatibility of the deprecated
configuration
##########
apisix/plugins/clickhouse-logger.lua:
##########
@@ -31,7 +32,7 @@ local batch_processor_manager =
bp_manager_mod.new(plugin_name)
local schema = {
type = "object",
properties = {
- endpoint_addr = core.schema.uri_def,
Review Comment:
Would be better to keep the old conf and mark it as deprecated?
Like
https://github.com/apache/apisix/blob/1771c51f94d1c5c4f6542a9d90c7c1d777b992d2/apisix/stream/plugins/mqtt-proxy.lua#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
