tzssangglass commented on code in PR #7517:
URL: https://github.com/apache/apisix/pull/7517#discussion_r929531364
##########
t/plugin/clickhouse-logger.t:
##########
@@ -171,11 +183,53 @@ property "endpoint_addr" is required
}
}
--- response_body
+{"error_msg":"failed to check the configuration of plugin clickhouse-logger
err: property "endpoint_addr" validation failed: wrong type: expected array,
got string"}
+--- error_code: 400
+
+
+
+=== TEST 5: add plugin on routes using multi clickhouse-logger
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "plugins": {
+ "clickhouse-logger": {
+ "user": "default",
+ "password": "a",
+ "database": "default",
+ "logtable": "t",
+ "endpoint_addr":
["http://127.0.0.1:10420/clickhouse-logger/test";,
Review Comment:
since `endpoint_addr` is marked as deprecated, should we use `host` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
