spacewander commented on code in PR #7517: URL: https://github.com/apache/apisix/pull/7517#discussion_r929540725
########## docs/en/latest/plugins/clickhouse-logger.md: ########## @@ -35,7 +35,7 @@ The `clickhouse-logger` Plugin is used to push logs to [ClickHouse](https://clic | Name | Type | Required | Default | Valid values | Description | |---------------|---------|----------|---------------------|--------------|----------------------------------------------------------------| -| endpoint_addr | string | True | | | ClickHouse endpoint. | Review Comment: ``` | endpoint_addr | string | True | | | Deprecated, use `endpoint_addrs` instead. ClickHouse endpoint. | | endpoint_addrs | array | True | | | ClickHouse endpoints. | ``` ########## apisix/plugins/clickhouse-logger.lua: ########## @@ -31,7 +32,8 @@ local batch_processor_manager = bp_manager_mod.new(plugin_name) local schema = { type = "object", properties = { - endpoint_addr = core.schema.uri_def, + -- deprecated, use "host" instead + endpoint_addr = {items = core.schema.uri_def, type = "array", minItems = 1}, Review Comment: In fact, I suggest to use: ``` -- deprecated, use "endpoint_addrs" instead endpoint_addr = core.schema.uri_def, endpoint_addrs = {items = core.schema.uri_def, type = "array", minItems = 1}, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
