AlinsRan commented on code in PR #837:
URL: https://github.com/apache/apisix-helm-chart/pull/837#discussion_r2174265532


##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -215,79 +12,66 @@ podDisruptionBudget:
   minAvailable: 90%
   # -- Set the maxUnavailable of podDisruptionBudget
   maxUnavailable: 1
+# -- Topology Spread Constraints for pod assignment spread across your cluster 
among failure-domains
+# ref: 
https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/#spread-constraints-for-pods
 
-podSecurityContext: {}
-  # fsGroup: 2000
-
-securityContext: {}
-  # capabilities:
-  #   drop:
-  #   - ALL
-  # readOnlyRootFilesystem: true
-  # runAsNonRoot: true
-  # runAsUser: 1000
-gateway:
-  # -- Apache APISIX service type for user access itself
-  type: NodePort
-  externalTrafficPolicy: Cluster
-  # annotations:
-  #   service.beta.kubernetes.io/aws-load-balancer-type: nlb
-  # loadBalancerIP: a.b.c.d
-  # loadBalancerSourceRanges:
-  #   - "143.231.0.0/16"
-  # -- load balancer ips
-  externalIPs: []
-  nginx:
-    # -- Nginx workerRlimitNoFile
-    workerRlimitNofile: "20480"
-    # -- Nginx worker connections
-    workerConnections: "10620"
-    # -- Nginx worker processes
-    workerProcesses: auto
-    # -- Nginx error logs path
-    errorLog: stderr
-    # -- Nginx error logs level
-    errorLogLevel: warn
-    # -- Custom configuration snippet.
-    configurationSnippet:
-      main: |
-
-      httpStart: |
-
-      httpEnd: |
-
-      httpSrv: |
+autoscaling:
+  enabled: false
+  minReplicas: 1
 
-      httpAdmin: |
+deployment:
+  annotations: {}
+  podAnnotations: {}
+  replicas: 1
+  nodeSelector: {}
+  tolerations: []
+  affinity: {}
+  podSecurityContext:
+    allowPrivilegeEscalation: false
+    capabilities:
+      drop:
+        - ALL
+  topologySpreadConstraints: []
+  image:
+    repository: apache/apisix-ingress-controller
+    pullPolicy: IfNotPresent
+    tag: "dev"
 
-      stream: |
+config:
+  logLevel: "info"
+  controllerName: apisix.apache.org/apisix-ingress-controller
+  leaderElection:
+    id: "apisix-ingress-controller-leader"
+    leaseDuration: "15s"
+    renewDeadline: "10s"
+    retryPeriod: "2s"
+    disable: false
+  metricsAddr: ":8080"
+  enableHTTP2: false
+  probeAddr: ":8081"
+  secureMetrics: ""

Review Comment:
   
https://github.com/apache/apisix-ingress-controller/blob/master/config/samples/config.yaml#L28
   
   It is a boolean value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to